96000HZ audio impliementation code submission.

Bahamut_ZERO_Clue · Post by **Bahamut_ZERO_Clue** » Thu Feb 23, 2006 4:37 am

Well I actually didn't think I could do it but I did it. Well, the sound is really messed up but it does work a little bit although I probably need to adjust the buffer rate a bit more. I'll keep pluggin away at it though.

================================================
line 504 of cfgload.c

- WRITE_LINE("; 6 = 48,000 Hz\r\n\r\n");
+WRITE_LINE("; 6 = 48,000 Hz, 7 = 96,000 Hz\r\n\r\n");

line 818 of winlink.cpp

+ case 7:
+ wfx.nSamplesPerSec = 96000;
+ SoundBufferSize=1024*12;
+ break;

line 951 of winlink.cpp

+ case 7:
+ wfx.nSamplesPerSec = 96000;
+ SoundBufferSize=1024*12;
+ break;

line 1833 of guiwindp.inc

+GUISoundTextB8 db '96000HZ',0

line 1412 of guikeys.inc

- .sampratenext db 1,4,5,6,2,3,0,0,0,0
+.sampratenext db 1,4,5,6,2,3,7,0,0,0

line 2578 of guimouse.inc

- sampratenext db 1,4,5,6,2,3,0,0,0,0
+sampratenext db 1,4,5,6,2,3,7,0,0,0

================================================

Well Nach here's 50 dollars worth of coding dude. JK:P... I'll try and contribute something to the ZSnes project when I get a chance.

Money's been tight since I recently got a new job but I'll do anything I can that will help even if only miniscule.

Deathlike2 · Post by **Deathlike2** » Thu Feb 23, 2006 4:50 am

WOW.

I didn't think you were going to go this far to get it in...

Bahamut_ZERO_Clue · Post by **Bahamut_ZERO_Clue** » Thu Feb 23, 2006 4:53 am

Well, it from the edit it sounds aweful but it does prove it can be done with some minor adjustments to the output buffer.

Edit:

I did some reasearch into the problem and I THINK it's somehow connected to the MinGW DirectSound code which is still DX8 and AFAIK DX8 never had any support for 24bit/96khz audio chipsets and cards or impliementations on that part but I'll keep reasearching. I'll get this right or... any help or assistance would be nice.

Starman Ghost · Post by **Starman Ghost** » Thu Feb 23, 2006 5:45 am

You know the 50$ was a joke right?

Bahamut_ZERO_Clue · Post by **Bahamut_ZERO_Clue** » Thu Feb 23, 2006 5:59 am

Yeah

I got the joke. Took me a few moments but I got it. Anywho any suggestions or comments?

Deathlike2 · Post by **Deathlike2** » Thu Feb 23, 2006 6:33 am

Bahamut_ZERO_939 wrote:Well, it from the edit it sounds aweful but it does prove it can be done with some minor adjustments to the output buffer.

Edit:

I did some reasearch into the problem and I THINK it's somehow connected to the MinGW DirectSound code which is still DX8 and AFAIK DX8 never had any support for 24bit/96khz audio chipsets and cards or impliementations on that part but I'll keep reasearching. I'll get this right or... any help or assistance would be nice.

I don't really think that's the case...

Some stuff I found with Google...
http://support.microsoft.com/?id=316638
http://support.microsoft.com/kb/308883/EN-US/
http://kxproject.lugosoft.com/tech.php?language=en

Bahamut_ZERO_Clue · Post by **Bahamut_ZERO_Clue** » Thu Feb 23, 2006 6:42 am

So basically until this can be fixed within Windows you'd have to downmix the 96khz to something like 48khz or less... or get the hotfix.

Deathlike2 · Post by **Deathlike2** » Thu Feb 23, 2006 6:50 am

Bahamut_ZERO_939 wrote:So basically until this can be fixed within Windows you'd have to downmix the 96khz to something like 48khz or less... or get the hotfix.

Mmm... it's been fixed... but if you didn't understand the context of the fixes, they explain in their descriptions that 24-bit audio is allowable for DirectSound...

Strangely enough, I don't know why we're never able to manually adjust the audio bitrate (I think that's the correct term)... hmm..

Bahamut_ZERO_Clue · Post by **Bahamut_ZERO_Clue** » Fri Feb 24, 2006 3:18 am

Yeah and it looks like ZSnes is using a bitrate of 16 currently as read from lines... I'd like to see what Nach did to get some ideas.

byuu · Post by **byuu** » Fri Feb 24, 2006 8:35 am

Yeah and it looks like ZSnes is using a bitrate of 16 currently as read from lines...

uint32 sample_24 = uint16(sample_16) << 8;

Or if you really want to go all out here:
sample_24 = (sample_16 << 8) | (sample_16 >> 8);

Can't you at least just use 96khz with 16-bit samples? You're basically just making up data that isn't there. At all.

Post by **pagefault** » Fri Feb 24, 2006 3:05 pm

http://zsnes.game-host.org/~pagefault/top.ogg

This is what your code produces.

Post by **grinvader** » Fri Feb 24, 2006 3:17 pm

Great coding there, Bahamut.

creaothceann · Post by **creaothceann** » Fri Feb 24, 2006 3:23 pm

pagefault wrote:http://zsnes.game-host.org/~pagefault/top.ogg

This is what your code produces.

Awful, but somehow funny...

Lord Alpha · Post by **Lord Alpha** » Fri Feb 24, 2006 6:24 pm

creaothceann wrote:
pagefault wrote:http://zsnes.game-host.org/~pagefault/top.ogg

This is what your code produces.
Awful, but somehow funny...

Agreed. Maybe this should be put in ZSNES anyway, as an easter egg or something

(j/k)

FitzRoy · Post by **FitzRoy** » Fri Feb 24, 2006 11:17 pm

Ironic hilarity.

funkyass · Post by **funkyass** » Fri Feb 24, 2006 11:19 pm

Deathlike2 · Post by **Deathlike2** » Fri Feb 24, 2006 11:52 pm

snkcube · Post by **snkcube** » Fri Feb 24, 2006 11:56 pm

pagefault wrote:http://zsnes.game-host.org/~pagefault/top.ogg

This is what your code produces.

Oh man, I can't stop laughing.

-_pentium5.1_- · Post by **-_pentium5.1_-** » Mon Feb 27, 2006 6:05 am

Um, what exactly is the problem with this code? If it generates 24-bit samples, it should be modified to generate 16-bit samples. (Sorry if I'm not reading the code carefully enough. DirectSound *does* support 96kHz x 16bits, right?) Since 96kHz is exactly 3 times 32kHz, it should theoretically be possible to get very clean sound with proper buffering. I know I'm not taking enough time to understand the issue, but what exactly is holding this code back from production?

Starman Ghost · Post by **Starman Ghost** » Mon Feb 27, 2006 6:10 am

-_pentium5.1_- wrote:Um, what exactly is the problem with this code? If it generates 24-bit samples, it should be modified to generate 16-bit samples. (Sorry if I'm not reading the code carefully enough. DirectSound *does* support 96kHz x 16bits, right?) Since 96kHz is exactly 3 times 32kHz, it should theoretically be possible to get very clean sound with proper buffering. I know I'm not taking enough time to understand the issue, but what exactly is holding this code back from production?

Did you listen to pagefault's recorded output with his code? It doesn't work.

franpa · Post by **franpa** » Mon Feb 27, 2006 6:27 am

winamp reports it as 44khz isnt it meant to be 96khz 24bit?

Aerdan · Post by **Aerdan** » Mon Feb 27, 2006 2:19 pm

It's 44kHz at 96kHz speed.

Bahamut_ZERO_Clue · Post by **Bahamut_ZERO_Clue** » Wed Mar 01, 2006 3:35 am

AFAIK DirectSound can only produce up to 48000hz with 16bit samples, I'm still researching and I haven't had too much time to work on this. I have some time this week do do some more coing so I'll get back to work and see what I can figure out.

BTW I know it sounds like a cat getting rubbed by a cheese graiter (aka awful as hell). 24bit sampling is needed for anything over (again) 48khz AFAIK.

xaimus · Post by **xaimus** » Wed Mar 01, 2006 3:43 am

pagefault wrote:http://zsnes.game-host.org/~pagefault/top.ogg

This is what your code produces.

ahaha
ahahha
AHAHAHHHAAAHAHAAH

I haven't laughed this hard in a loooong time.

kode54 · Post by **kode54** » Wed Mar 01, 2006 12:36 pm

Bahamut_ZERO_939 wrote:AFAIK DirectSound can only produce up to 48000hz with 16bit samples

No.

BTW I know it sounds like a cat getting rubbed by a cheese graiter (aka awful as hell). 24bit sampling is needed for anything over (again) 48khz AFAIK.

No again.

You missed all the lovely tables in cpu/dspproc.asm. BufferSize, BufferSizes, SoundSpeeds, SBToSPCSpeeds, NumofSPCBlock... No, wait, I'm making this too easy for you.

For a start, maybe you should make the effort to test this crap on your own system before submitting patches. Not like you'll notice over all the placebo.